Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eza: init at 0.10.4 #246050

Merged
merged 1 commit into from
Aug 4, 2023
Merged

eza: init at 0.10.4 #246050

merged 1 commit into from
Aug 4, 2023

Conversation

cafkafk
Copy link
Member

@cafkafk cafkafk commented Jul 29, 2023

Description of changes

Due to exa being without any active maintainers, I and another contributor have created a fork.

Several major pull requests, as well as security fixes have already been made:

Changelog (general):

  • Merged pr-1177: add hyperlink support
  • Merged pr-855: add selinux context outputs
  • Merged pr-797: git repo status, current branch
  • Merged pr-1219: fish inode completions
  • Merged pr-1164: -o shortcut for --octal-permissions
  • Merged pr-1099: typo
  • Merged pr-69: fix cargo.toml, completions, man pages
  • Merged pr-981: use stdout for timezone errors

Changelog (security):

  • Bumped openssl-src: SM2 Decryption Buffer Overflow (Critical)
  • Bumped openssl-src: openssl-src contains Double free after calling PEM_read_bio_ex (High)
  • Bumped openssl-src: AES OCB fails to encrypt some bytes (High)
  • Bumped openssl-src: openssl-src's infinite loop in BN_mod_sqrt() reachable when parsing certificates (High)
  • Bumped openssl-src: Read buffer overruns processing ASN.1 strings (High)
  • Bumped openssl-src: openssl-src vulnerable to Use-after-free following BIO_new_NDEF (High)
  • Bumped openssl-src: Vulnerable OpenSSL included in cryptography wheels (High)
  • Bumped openssl-src: openssl-src subject to Timing Oracle in RSA Decryption (Moderate)
  • Bumped git2-rs: git2-rs fails to verify SSH keys by default (Moderate)
  • Bumped git2-rs: git2-rs fails to verify SSH keys by default (Moderate)

I think the security issue alone speak for the creation of this package (the features added equally so).

Everything is working, including autocompletions.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@cafkafk
Copy link
Member Author

cafkafk commented Aug 1, 2023

Also, release tag is wrong on git for 0.10.3, I'll use I used the idiomatic substitution for 0.10.4.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2485

@fpletz fpletz changed the title init: eza at unstable-2023-07-29 init: eza at 0.10.4 Aug 2, 2023
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested & looking good!

Could you please squash your commit to have only the init commit? Thanks!

@fpletz fpletz changed the title init: eza at 0.10.4 eza: init at 0.10.4 Aug 2, 2023
eza: init at unstable-2023-07-29

Changelog (general):
- Merged pr-1177: add hyperlink support
- Merged pr-855: add selinux context outputs
- Merged pr-797: git repo status, current branch
- Merged pr-1219: fish inode completions
- Merged pr-1164: -o shortcut for --octal-permissions
- Merged pr-1099: typo
- Merged pr-69: fix cargo.toml, completions, man pages
- Merged pr-981: use stdout for timezone errors

Changelog (security):
- Bumped openssl-src: SM2 Decryption Buffer Overflow (Critical)
- Bumped openssl-src: openssl-src contains Double free after calling `PEM_read_bio_ex` (High)
- Bumped openssl-src: AES OCB fails to encrypt some bytes (High)
- Bumped openssl-src: openssl-src's infinite loop in `BN_mod_sqrt()` reachable when parsing certificates (High)
- Bumped openssl-src: Read buffer overruns processing ASN.1 strings (High)
- Bumped openssl-src: openssl-src vulnerable to Use-after-free following `BIO_new_NDEF` (High)
- Bumped openssl-src: Vulnerable OpenSSL included in cryptography wheels (High)
- Bumped openssl-src: openssl-src subject to Timing Oracle in RSA Decryption (Moderate)
- Bumped git2-rs: git2-rs fails to verify SSH keys by default (Moderate)
- Bumped git2-rs: git2-rs fails to verify SSH keys by default (Moderate)

Signed-off-by: Christina Sørensen <christina@cafkafk.com>

eza: unstable-2023-07-29 -> unstable-2023-07-30

Signed-off-by: Christina Sørensen <christina@cafkafk.com>

eza: unstable-2023-07-30 -> 0.10.2

Signed-off-by: Christina Sørensen <christina@cafkafk.com>

eza: 0.10.2 -> 0.10.3

Signed-off-by: Christina Sørensen <christina@cafkafk.com>

eza: 0.10.3 -> 0.10.4

Changelog:

Bug Fixes

- Dereferencing linksfile size.
- Dereferencing links users.
- Dereferencing links groups.
- Dereferencing links permissions.
- Dereferencing links timestamps.
- Syntax error

Documentation

- Add -X/--dereference flag

Features

- Add symlink dereferencing flag
- Add -X/--dereference completions
- Add -X/--dereference completions
- Added ".out" files for latex
- Add changelog generation

Signed-off-by: Christina Sørensen <christina@cafkafk.com>
@cafkafk
Copy link
Member Author

cafkafk commented Aug 2, 2023

Tested & looking good!

TYSM for reviewing this! Glad to see it worked!

Could you please squash your commit to have only the init commit? Thanks!

Yes! This should have done it.

Also changed commit summary s/init: eza/eza: init/, guess this is the idiomatic way?

@Lassulus Lassulus merged commit d6f28f6 into NixOS:master Aug 4, 2023
8 checks passed
@SebTM
Copy link
Contributor

SebTM commented Nov 11, 2023

Is there a possibility to back-port the replacement to nixpkgs-23.05?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants